Drop Dockerfile in test images#1792
Merged
knative-prow-robot merged 10 commits intoknative:masterfrom Aug 10, 2018
yolocs:ko_testimg
Merged
Drop Dockerfile in test images#1792knative-prow-robot merged 10 commits intoknative:masterfrom yolocs:ko_testimg
knative-prow-robot merged 10 commits intoknative:masterfrom
yolocs:ko_testimg
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1720
Not sure if this is the right way of doing this.
This will change the repo for test images:
e.g.
gcr.io/myproj/knative-serving=>gcr.io/myproj//github.com/knative/serving/test/conformance/test_imagesAnd the repo will be different for e2e and comformance tests unless we move all test images to a single import path, e.g.
github.com/knative/serving/test/images